Fix flaky config specs caused by STDERR.reopen#1832
Merged
viktorerlingsson merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
STDERR.reopen in the "log warning" specs corrupted Crystal's event loop fd registration, causing intermittent "File not open for writing" errors in other config specs when run in random order. Add @io constructor param to Config (defaulting to STDERR) and route all warning/error output through it. Specs that verify warning text now pass an IO::Memory instead of redirecting STDERR.
|
PR Review: No issues found. The refactoring cleanly replaces STDERR redirection with dependency injection of an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ioconstructor param toConfig(defaults toSTDERR) and route all warning/error output through itIO::Memoryinstead of usingSTDERR.reopenConfig.initializereopening inspec_helper.crOptionstruct by removing@deprecation_warn_msgand@iofieldsRoot cause
STDERR.reopenin the "log warning" specs corrupted Crystal's event loop fd registration for fd 2, causing intermittentFile not open for writingerrors in other config specs under--order random.🤖 Generated with Claude Code